Skip to content

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 28, 2025

User description

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed


PR Type

Enhancement


Description

  • Update Firefox beta version from 145.0b6 to 145.0b7

  • Update Linux beta Firefox binary URL and SHA256 hash

  • Update macOS beta Firefox binary URL and SHA256 hash


Diagram Walkthrough

flowchart LR
  A["Firefox 145.0b6"] -- "version bump" --> B["Firefox 145.0b7"]
  B -- "update URLs" --> C["Linux & macOS binaries"]
  C -- "update hashes" --> D["SHA256 checksums"]
Loading

File Walkthrough

Relevant files
Configuration changes
repositories.bzl
Update Firefox beta version and binary checksums                 

common/repositories.bzl

  • Update Linux beta Firefox URL from 145.0b6 to 145.0b7 with new SHA256
    hash
  • Update macOS beta Firefox URL from 145.0b6 to 145.0b7 with new SHA256
    hash
  • Maintain consistent build file content structure across
    platform-specific archives
+4/-4     

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Oct 28, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 28, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No audit impact: The PR only updates third-party archive URLs and hashes and does not introduce or modify
any action logging; verification is needed to ensure no implicit logging requirements are
affected.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/145.0b7/linux-x86_64/en-US/firefox-145.0b7.tar.xz",
        sha256 = "7d672485d8162480b23d86bb2042e6476ce70020e6a406964ac78e1012495167",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
Missing error handling: The new archive URL and sha256 values are set without visible fallback or validation in
this diff, so failures to fetch or verify the archives may not be handled here.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/145.0b7/linux-x86_64/en-US/firefox-145.0b7.tar.xz",
        sha256 = "7d672485d8162480b23d86bb2042e6476ce70020e6a406964ac78e1012495167",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)
  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 28, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Centralize version string in a variable

To improve maintainability, define the Firefox beta version in a variable and
use it to construct the download URLs, making future updates easier.

common/repositories.bzl [51-77]

+_FIREFOX_BETA_VERSION = "145.0b7"
+
 http_archive(
     name = "linux_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/145.0b7/linux-x86_64/en-US/firefox-145.0b7.tar.xz",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/{v}/linux-x86_64/en-US/firefox-{v}.tar.xz".format(v = _FIREFOX_BETA_VERSION),
     sha256 = "7d672485d8162480b23d86bb2042e6476ce70020e6a406964ac78e1012495167",
     build_file_content = """
 ...
 )
 
 dmg_archive(
     name = "mac_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/145.0b7/mac/en-US/Firefox%20145.0b7.dmg",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/{v}/mac/en-US/Firefox%20{v}.dmg".format(v = _FIREFOX_BETA_VERSION),
     sha256 = "d0e665953c0fcbb858dc3742f8f5aba2ad75eee3b38d7b9403e3a33fe7233fb1",
     build_file_content = """
 ...
 )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies hardcoded version strings and proposes using a variable to improve maintainability, which is a valuable refactoring for this type of configuration file.

Low
  • Update

@diemol diemol merged commit 189f556 into trunk Oct 28, 2025
46 of 47 checks passed
@diemol diemol deleted the pinned-browser-updates branch October 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants